Thank you for the PR @gumbarros! After a first glance at the code, it looks quite good. A few tings are still to be done.

1. There is one or more failing tests.
2. The new config parameter also has to be read from config files (check out the code in src/Serilog.Sinks.MSSqlServer/Configuration)
3. Add tests for the new functionality (especially in SqlTableWriter)

Yw @ckadluba, sorry for the late response.

I have added support for reading the new config parameter from the config files. However, I'm not very familiar with the test setup and I'm feeling a bit overwhelmed by the complexity of fixing and writing the tests. I'd really appreciate some help from someone with that part.

Thank you for the updates on the PR. I'll try to take a look at it tomorrow and I will also try to help with the tests.

Hi @gumbarros!

I reviewed your PR. It looks quite good basically but it had to make made some fixes and add some tests (nothing big). My changes are pushed here: https://github.com/ckadluba/serilog-sinks-mssqlserver/tree/issue-636-timestamp-indexdirection. Please pull them into your branch and update the PR, then we should be ready to merge.

Cheers,
Christian

Hi @gumbarros!

I reviewed your PR. It looks quite good basically but it had to make made some fixes and add some tests (nothing big). My changes are pushed here: https://github.com/ckadluba/serilog-sinks-mssqlserver/tree/issue-636-timestamp-indexdirection. Please pull them into your branch and update the PR, then we should be ready to merge.

Cheers, Christian

Thank you, I made the pull and it said everything is fine, can you run CI again?

Cheers,

Gustavo